Remove a publishing-related config-cache disabler #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(continuation from #3562 (comment))
This PR drops the workaround for disabling configuration cache during publishing. There were proposals to replace it with
MavenPublishLimiter, but it looks like it's not needed for now? We'll be publishing to Maven Central withDOKKA_MVN_CENTRAL_REPOSITORY_ID, and Gradle Plugin Portal and Space seem to handle parallelization wellI'm definitely missing some lazy verifications around publishing in Gradle :) It'd be nice to check that
DOKKA_MVN_CENTRAL_REPOSITORY_IDis set and not blank when publishing to Maven Central, then we would be able to drophttps://oss.sonatype.org/service/local/staging/deploy/maven2/completely. But since the configuration is resolved during build time, it doesn't seem like there's an easy way to do it? Not a huge deal at all, just something that I think would be nice to have to enforce the publishing rules