Fix external documentation link default values #3812
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
runner: Gradle plugin
Tapchicoma
reviewed
Sep 19, 2024
| @@ -218,7 +218,7 @@ constructor( | |||
| } | |||
|
|
|||
| maybeCreate("jdk") { | |||
| enabled.convention([email protected]) | |||
| enabled.set([email protected]) | |||
There was a problem hiding this comment.
Hm, why does convention not work here?
There was a problem hiding this comment.
I believe it gets overridden by the configureEach {} above, which sets the convention to true.
dokka/dokka-runners/dokka-gradle-plugin/src/main/kotlin/DokkaBasePlugin.kt
Lines 214 to 218 in f4b0ad9
There was a problem hiding this comment.
Could it skip these known names like if(name !in setOf("jdk", "kotlinStdlib", "androidSdk", "androidX"))?
Usually using actual values instead of conventions in entities that could be configured by users are a code smell.
whyoleg
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the default value of
truefrom overriding the specific values provided from the top level Dokka DSL.KT-70908