Move GradlePropertiesBuilder test util to separate class #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
runner: Gradle plugin
Moving GradlePropertiesBuilder to a separate class will permit reusing it in Dokka integration tests that will be introduced in PR #3904
adam-enko
force-pushed
the
adam/feat/move-GradleProperties-builder
branch
from
e4b59f3
to
eaa8bfa
Compare
whyoleg
approved these changes
Nov 5, 2024
Tapchicoma
approved these changes
Nov 7, 2024
| /** | ||
| * Specifies the scheduling priority for the Gradle daemon and all processes launched by it. | ||
| */ | ||
| var daemonSchedulingPriority: SchedulingPriority? = SchedulingPriority.Low, |
There was a problem hiding this comment.
JC: why do you need this option in tests?
There was a problem hiding this comment.
A few reasons:
- My big-picture far-future plan is to create a general TestKit utilities library, and so I wanted to include as many options as possible to make this utility comprehensive.
- "Just in case" and "why not?"
- If a test fails I might open up the project in my IDE/terminal and it's helpful to avoid a high prio daemon (since it's only a test project), but I also want to make sure I have the same properties as the test, for consistency.
These aren't strong reasons, so maybe there's a good reason not to have it?
Comment on lines
+15
to
+17
| val gradle: GradleArgs = GradleArgs(), | ||
| val dokka: DokkaArgs = DokkaArgs(), | ||
| val kotlin: KotlinArgs = KotlinArgs(), |
There was a problem hiding this comment.
I like this separation of args! We should do the same in KGP/IT/BuildOptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving GradlePropertiesBuilder to a separate class will permit reusing it in Dokka integration tests that will be introduced in PR #3904