Command-line control over scalar-valued set routines #662
+647
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
gardner48
reviewed
Feb 19, 2025
Co-authored-by: Steven Roberts <[email protected]>
… since that causes compilation warnings/errors because main() uses char* argv[].
…uld be matched to process command-line arguments, which should support MRI and operator-splitting
|
I think I've finished revising the previous implementation according to the initial feedback. It would be great if folks who looked at this previously would give it another look. Once you're happy with the structure, I'll get started on the ARKODE stepper-specific functions, other integrators, linear solvers, nonlinear solvers, etc. |
…ber of options in each category. Co-authored-by: Steven Roberts <[email protected]>
…l call ARKodeWriteParameters after setting all command-line inputs.
…ons (none are implemented yet)
…lled in), along with comments to myself on next steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this up as a draft PR to get feedback on the approach before I update the other packages (CVODE, CVODES, IDA, IDAS, KINSOL), and the various class implementations (
SUNLinearSolver,SUNAdaptController,SUNNonlinearSolver, etc).We can discuss this during an upcoming group meeting, if desired. @balos1 and I have scaled back the previous plans to account for the reduced manpower allocated to the task, so we're only focusing on command-line control for now (YAML or other file-based inputs have been deferred).