Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Promyvion] Add elemental functionality to Empty-type mobs #7069

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Xaver-DaRed
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Makes mobs choose an element and change their resistances, model and subanimation accordingly.
Loot variation depending on element chosen will be handled in a different PR.

Also adds a testing module that compares a lot of different empty models and subanimations. Its meant for testing purposes, for the inevitable time this has to be revisited.
imagen

Steps to test these changes

Run promyvions. Yeah, it still is boring without level cap, but mobs have random elements now.

@zach2good zach2good merged commit d899965 into LandSandBoat:base Feb 18, 2025
13 checks passed
@Xaver-DaRed Xaver-DaRed deleted the promyvion-elements branch February 20, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants