Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gulp workflow #147 #148

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

add gulp workflow #147 #148

wants to merge 1 commit into from

Conversation

zellwk
Copy link

@zellwk zellwk commented Sep 23, 2016

Signed-off-by: Zell Liew [email protected]

Signed-off-by: Zell Liew <[email protected]>
@LeaVerou
Copy link
Owner

Thanks for working on this! However, I see several issues that prevent me from merging this for now:

  • Obsolete prefixed properties and functions have been added, such as -webkit-transform or -webkit-linear-gradient(). The target browser support for this project is recent versions of evergreen browsers, since slides are a controlled environment.
  • Inline source maps add weight
  • I personally find mandatory auto-browser reload quite annoying and wouldn't want to impose it on people.
  • You didn't use git add . --all, so moved files are presented as new files, making it impossible to review their diff.

@zellwk
Copy link
Author

zellwk commented Oct 17, 2016

To be honest, I'm not sure if adding a gulp workflow would help if you don't want to:

  1. Reload the browser
  2. Preprocess / postprocess CSS
  3. Add vendor prefixes

imo, it doesn't add much value to just add cssnext, because it doesn't help much too. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants