Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to VuePress 2.0 #19

Merged
merged 20 commits into from
Jul 22, 2022
Merged

Bump to VuePress 2.0 #19

merged 20 commits into from
Jul 22, 2022

Conversation

Nofated095
Copy link
Contributor

No description provided.

Copy link
Contributor

@Cubik65536 Cubik65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes, or, I REFUSE these changes.

package.json Outdated Show resolved Hide resolved
@Nofated095 Nofated095 closed this Jun 18, 2022
@Nofated095
Copy link
Contributor Author

Nofated095 commented Jul 21, 2022

Production Review at https://ls-bot.9595095.xyz/ Will Close After Merged

vuepress/vuepress-next 生产环境使用beta是否合适 #955

@gxres042
Copy link
Contributor

@Cubik65536 Remember that LittleSkin Manual said that "LittleSkin use the DEV version of Blessing Skin"?

I think we can do that now. Why not try it?

Copy link
Contributor

@gxres042 gxres042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I have a require.

If bump to VuePress 2 can resolve the 14 security alerts that appear now, I agree to bump to VuePress 2.

@Cubik65536
Copy link
Contributor

@Cubik65536 Remember that LittleSkin Manual said that "LittleSkin use the DEV version of Blessing Skin"?

I think we can do that now. Why not try it?

I GIVE UP from talking about it. If you guys think it's the only thing important to do, then do it.

@gxres042
Copy link
Contributor

@Cubik65536 Remember that LittleSkin Manual said that "LittleSkin use the DEV version of Blessing Skin"?
I think we can do that now. Why not try it?

I GIVE UP from talking about it. If you guys think it's the only thing important to do, then do it.

No the most important thing.

I think it's necessary to get your options because you first request changes.

I propose a require to him to do. Just need to resolve all the security alerts that appears now. If he can't, maybe I will rebuild this bot manual with the latest STABLE VuePress.

Thanks for your reply. You can suggest any options to this. I will listen.

Copy link
Contributor

@Cubik65536 Cubik65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove change request

@Cubik65536 Cubik65536 dismissed their stale review July 21, 2022 14:55

Remove change request

@Nofated095
Copy link
Contributor Author

Nofated095 commented Jul 22, 2022

image
I deleted caches and rebuilt the VuePress.
Seems nothing was wrong expect source-map-resolve. Seems it's necessary for VuePress to use the package. It's not an "unmet peer dependency" problem.

@Nofated095
Copy link
Contributor Author

Nofated095 commented Jul 22, 2022

Now VuePress v2 still has some bugs that can be clearly perceived.
The commspt-bot-manual has a long title and VuePress can't hide the title correctly, especially on the mobile devices.
image

@gxres042 gxres042 merged commit c3c9b30 into LittleSkinCommspt:next Jul 22, 2022
gxres042 pushed a commit that referenced this pull request Jan 3, 2023
…ss/plugin-register-components-2.0.0-beta.60

Bump @vuepress/plugin-register-components from 2.0.0-beta.59 to 2.0.0-beta.60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants