feat: Add Max Bitrate option #3628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.15.0 resubmit
v0.15.0 resubmit
v0.15.0 resubmit
# Conflicts: # src/platform/windows/publish.cpp # src_assets/common/assets/web/config.html
# Conflicts: # docs/source/about/advanced_usage.rst
Add max bitrate 2
* added max bitrate to latest version * Trigger workflow * removed third party libraries that were making build fail * removed another unneeded library * updated tray ref * attempt 2 at updating tray * updated third party moonlight as well fuck this repo * added logging to see if max bitrate is working * removed extraneous l
ReenigneArcher
requested changes
Feb 3, 2025
src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue
Show resolved
Hide resolved
ReenigneArcher
requested changes
Feb 4, 2025
src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue
Outdated
Show resolved
Hide resolved
Check if max_bitrate is > 0 instead of equal Co-authored-by: ReenigneArcher <[email protected]>
…desSettings.vue
added line break
fixed some indentation
fixed label for id
placeholder should be the default value in most cases
added missing closing div
Co-authored-by: ReenigneArcher <[email protected]>
Removed unused variables Co-authored-by: ReenigneArcher <[email protected]>
|
ReenigneArcher
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Sorry, I just realized a few other issues. If the value is not set by the config file, then there is no default value in the cpp. I'd also like the config option as part of the video object instead of the nvhttp object.
Add default value here should fix that.
If you could also move this up to below min_fps_factor that would be ideal (same for config.h).
| @@ -1151,6 +1151,7 @@ namespace config { | |||
|
|
|||
| string_f(vars, "external_ip", nvhttp.external_ip); | |||
| list_prep_cmd_f(vars, "global_prep_cmd", config::sunshine.prep_cmds); | |||
| int_f(vars, "max_bitrate", nvhttp.max_bitrate); | |||
There was a problem hiding this comment.
I think this should be part of the video section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist