Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: create table from source: platform checks and testdrive #29362

Merged
merged 3 commits into from
Sep 9, 2024
Merged

tests: create table from source: platform checks and testdrive #29362

merged 3 commits into from
Sep 9, 2024

Conversation

nrainer-materialize
Copy link
Contributor

@nrainer-materialize nrainer-materialize commented Sep 4, 2024 •
edited
Loading

@nrainer-materialize nrainer-materialize added the T-testing Theme: tests or test infrastructure label Sep 4, 2024
@nrainer-materialize nrainer-materialize self-assigned this Sep 4, 2024
@nrainer-materialize nrainer-materialize force-pushed the tests/create-table-from-source branch 8 times, most recently from 962966a to 3b0c279 Compare September 5, 2024 15:11
@nrainer-materialize nrainer-materialize changed the title tests: create table from source tests: create table from source: platform checks Sep 6, 2024
@nrainer-materialize nrainer-materialize changed the title tests: create table from source: platform checks tests: create table from source: platform checks and testdrive Sep 6, 2024
@nrainer-materialize nrainer-materialize marked this pull request as ready for review September 6, 2024 07:37
@nrainer-materialize nrainer-materialize requested a review from a team as a code owner September 6, 2024 07:37
def-
def- approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other tests planned? I would have added it in parallel-workload too, or are you already working on that?

misc/python/materialize/checks/all_checks/source_tables.py Show resolved Hide resolved
@nrainer-materialize
Copy link
Contributor Author

Any other tests planned? I would have added it in parallel-workload too, or are you already working on that?

Absolutely. I am currently about to migrate all existing tests (and additionally keep the original CDC tests).

rjobanp
rjobanp approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@rjobanp rjobanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

misc/python/materialize/checks/all_checks/source_tables.py Outdated
Testdrive(dedent(s))
for s in [
f"""
> CREATE TABLE mysql_table_1 FROM SOURCE mysql_source_{self.suffix} (REFERENCE "public_{self.suffix}"."mysql_source_table_1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add a text columns option here if we made one of the table columns an enum value or year value which are the 2 types that are unsupported natively and we've added text-columns support for: https://materialize.com/docs/sql/create-source/mysql/#supported-types

@nrainer-materialize nrainer-materialize merged commit 388649c into MaterializeInc:main Sep 9, 2024
43 checks passed
@nrainer-materialize nrainer-materialize deleted the tests/create-table-from-source branch September 9, 2024 11:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@def- def- def- approved these changes

@rjobanp rjobanp rjobanp approved these changes

Assignees

@nrainer-materialize nrainer-materialize

Labels
T-testing Theme: tests or test infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrainer-materialize @def- @rjobanp