Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: create table from source: cargo tests #29495

Merged
merged 1 commit into from
Sep 16, 2024
Merged

tests: create table from source: cargo tests #29495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/environmentd/src/test_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,6 +1051,7 @@ pub async fn get_explain_timestamp_determination(
/// WARNING: If multiple tests use this, and the tests are run in parallel, then make sure the test
/// use different postgres tables.
pub async fn create_postgres_source_with_table<'a>(
server: &TestServer,
mz_client: &Client,
table_name: &str,
table_schema: &str,
Expand All @@ -1059,6 +1060,10 @@ pub async fn create_postgres_source_with_table<'a>(
Client,
impl FnOnce(&'a Client, &'a Client) -> LocalBoxFuture<'a, ()>,
) {
server
.enable_feature_flags(&["enable_create_table_from_source"])
.await;

let postgres_url = env::var("POSTGRES_URL")
.map_err(|_| anyhow!("POSTGRES_URL environment variable is not set"))
.unwrap();
Expand Down Expand Up @@ -1138,8 +1143,15 @@ pub async fn create_postgres_source_with_table<'a>(
"CREATE SOURCE {source_name}
FROM POSTGRES
CONNECTION pgconn
(PUBLICATION '{source_name}')
FOR TABLES ({table_name});"
(PUBLICATION '{source_name}')"
))
.await
.unwrap();
mz_client
.batch_execute(&format!(
"CREATE TABLE {table_name}
FROM SOURCE {source_name}
(REFERENCE {table_name});"
))
.await
.unwrap();
Expand Down
12 changes: 9 additions & 3 deletions src/environmentd/tests/sql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,9 +1760,14 @@ async fn test_timeline_read_holds() {

let view_name = "v_hold";
let source_name = "source_hold";
let (pg_client, cleanup_fn) =
test_util::create_postgres_source_with_table(&mz_client, view_name, "(a INT)", source_name)
.await;
let (pg_client, cleanup_fn) = test_util::create_postgres_source_with_table(
&server,
&mz_client,
view_name,
"(a INT)",
source_name,
)
.await;

// Create user table in Materialize.
mz_client
Expand Down Expand Up @@ -1836,6 +1841,7 @@ async fn test_session_linearizability(isolation_level: &str) {
let pg_table_name = "v_lin";
let pg_source_name = "source_lin";
let (pg_client, cleanup_fn) = test_util::create_postgres_source_with_table(
&server,
&mz_client,
pg_table_name,
"(a INT)",
Expand Down
Loading