-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualify all references issue numbers in the materialize repo #29646
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We have files ending on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many occurrences that are not caught. I will try to add some more.
…ng the materialize# prefix to the number.
0bf1196
to
c584788
Compare
Rebased and replaced further matches. I only operated on TODOs. There are tons of further issue references in lines without TODOs. |
@def-: I am sure I still did not catch all of them. Can we emit warnings in the ci-issue-detector when it detects non-qualified issue numbers? |
Do this by adding the
materialize#
prefix to the issue number.E.g. Make
TODO(#1234)
insteadTODO(materialize#1234)
.This is in preparation for making github issues private. The old links will still work and redirect to the correct issue in the new repo, but the issues will have different ids in the new repo after the migration, so the TODOs should be clear about which repo the number is referring to.
Motivation
This PR refactors existing code. In service of the plans to make Github issues private, and use Github discussions for public tracking instead.
Tips for reviewer
Are there other potential variants of this that I may have missed?
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.