Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Allow reading back data in structured order #29666

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Sep 19, 2024

Motivation

Part of #24830 - allows reading back data in the structured-data order.

Before this change, we could configure Persist to compact data in the new structured-data order, but when we were consolidating at read time we'd reorder it back to the codec order. This is inefficient, and we'd like to allow callers to rely on the sorted order of data in the future for things like PARTITION BY.

Tips for reviewer

This uses the same ordering flag as the compaction side, which is a little weird: when we first flip the flag, we'll start using the new order for the fast-path peeks before there's any meaningful percentage of batch parts in the new order. It's possible we'll want to add fancier knobs for the true rollout, but this is enough to toggle things in CI / staging for now.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@bkirwi bkirwi force-pushed the structured-read branch 2 times, most recently from 09939a9 to 17c6550 Compare September 19, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant