Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workload-identity-overview.md #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miqm
Copy link

@miqm miqm commented Nov 12, 2024

Changed description of skip-containers annotation. The pod is labeled with azure.workload.identity/use: true, not the service account.

Changed description of skip-containers annotation. The pod is labeled with `azure.workload.identity/use: true`, not the service account.
Copy link
Contributor

@miqm : Thanks for your contribution! The author(s) have been notified to review your proposed change. @tamram

Copy link

Learn Build status updates of commit 4adb8f7:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/workload-identity-overview.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 12, 2024

@cynthn
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@cynthn cynthn removed their assignment Nov 12, 2024
@cynthn
Copy link
Contributor

cynthn commented Nov 12, 2024

@Jak-MS I'm not on the AKS team. The last one that was assigned to me was picked up by @schaffererin :)

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 12, 2024

@schaffererin - can you review? (also, if you could update the author metadata on articles that belonged to @tamram - that would be very helpful.) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants