Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newdiscretization #299

Open
wants to merge 36 commits into
base: dev
Choose a base branch
from
Open

Newdiscretization #299

wants to merge 36 commits into from

Conversation

softmattertheory
Copy link
Contributor

Implements additional finite element discretizations, including:

  • discretization.c/.h - Describe finite element function spaces; currently implements CG1 and CG2.
  • integrate.c/.h - quadrature routines updated.
  • functionals.c/.h - LineIntegral and AreaIntegral updated.

Test cases added.

softmattertheory and others added 29 commits January 11, 2025 13:24
@softmattertheory
Initial commit that builds
e719387
@softmattertheory
Integrate CG2 field correctly
7169182
@softmattertheory
Fix field initializer
79ecf64
@softmattertheory
Fix error generation
02b2135
@softmattertheory
Use linear interpolation if no interpolation function is given
478c02c
@softmattertheory
Test integrals of CG2 functions in 1 and 2 dimensions
3a0ea06
@softmattertheory
Remove old testing code
5d091d7
@softmattertheory
Grundmann nested quadrature rules for 2D
00b6251
@softmattertheory
Improve integrator performance
00b0cb3
@softmattertheory
Add cg2_grad test
61098c4
@softmattertheory
integralelementrefs now have barycentric coords
2a2d8b1
@softmattertheory
Work towards gradient information
9ea8280
@softmattertheory
tensor CG2 elements
1b401dd
@softmattertheory
CG update
9f05d68
@softmattertheory
2d elements embedded in 3D
2dda817
@softmattertheory
Fixes to test suite
9a9fdc9
@softmattertheory
Correct 3d rule name
6140949
@softmattertheory
Correct size of position vector
7463a6c
@softmattertheory
Change approach to error reporting in integrator
5bdb295
@softmattertheory
Error reporting from integrator configuration
e14a15e
@softmattertheory
Improved error reporting in integrator
959aec8
@softmattertheory
Restore old gradient calculation
c33457b
@softmattertheory
Update functional.c
c636dc7
@softmattertheory
Raise errors if gradient evaluation fails
c33817d
@softmattertheory
Test problem for interpolation on lower grade
0cc07af
@softmattertheory
discretization_lower to allow interpolation on lower grades
9e7eb81
@softmattertheory
Check for error in gradient evaluation
cc8d5be
@softmattertheory
Generate error if inverse jacobian is missing
a57a73c
@softmattertheory
Redesign discretization_doftofieldindx
6703618 
Field gradient evaluation now works for arbitrary fields in parallel.
@emmanuellfc
Copy link
Collaborator

The submitted pull request marks a key developmental milestone for Morpho with the integration of higher-order elements. Comprehensive testing, including installation and execution of the test suite, was performed, resulting in successful completion without errors. The installation procedure was executed seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshichaitanya3 joshichaitanya3 Awaiting requested review from joshichaitanya3

@emmanuellfc emmanuellfc Awaiting requested review from emmanuellfc

@ConduitDan ConduitDan Awaiting requested review from ConduitDan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@softmattertheory @emmanuellfc