Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template test instructions to use copier #437

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Aug 19, 2024

Swap out the old cookiecutter CLI instructions with the new copier instructions, specifically the copier copy command pointing to the branch for the PR.

Fixes #417

@sjvrijn sjvrijn requested review from fdiblen and lyashevska August 19, 2024 10:27
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, @sjvrijn. Thanks!

@sjvrijn sjvrijn force-pushed the 417-update-gh-pr-template branch from 2ea1aba to 41177d8 Compare August 19, 2024 11:54
@sjvrijn sjvrijn merged commit b07cc6d into dev Aug 19, 2024
@sjvrijn sjvrijn deleted the 417-update-gh-pr-template branch August 19, 2024 12:05
cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
cookiecutter -c <pr-branch> https://github.com/<pr-user>/python-template
# Use --vcs-ref <pr-branch> to point to the branch to you want to test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Use --vcs-ref <pr-branch> to point to the branch to you want to test
# Use --vcs-ref <pr-branch> to point to the branch you want to test

Copy link
Member

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sjvrijn Looks good, I made a few suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants