-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template test instructions to use copier #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, @sjvrijn. Thanks!
2ea1aba
to
41177d8
Compare
Co-authored-by: Olga Lyashevska <[email protected]>
cd $(mktemp -d --tmpdir py-tmpl-XXXXXX) | ||
cookiecutter -c <pr-branch> https://github.com/<pr-user>/python-template | ||
# Use --vcs-ref <pr-branch> to point to the branch to you want to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Use --vcs-ref <pr-branch> to point to the branch to you want to test | |
# Use --vcs-ref <pr-branch> to point to the branch you want to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sjvrijn Looks good, I made a few suggestions.
Swap out the old
cookiecutter
CLI instructions with the newcopier
instructions, specifically thecopier copy
command pointing to the branch for the PR.Fixes #417