Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ldns_calc_keytag() available for CDNSKEY RR #246

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Make ldns_calc_keytag() available for CDNSKEY RR #246

merged 1 commit into from
Aug 27, 2024

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Aug 27, 2024 •
edited
Loading

Initial work copied from #187, which was inadvertently closed when its author deleted his GitHub account.

Original PR description:

Hi, while working on CDS/CDNSKEY in Zonemaster I realized LDNS does not allow calling ldns_calc_keytag() on a CDNSKEY resource record (which is identical to a DNSKEY resource record).

@tgreenx tgreenx mentioned this pull request Aug 27, 2024
Merged
@wtoorop
Copy link
Member

wtoorop commented Aug 27, 2024

Thanks @tgreenx (and ghost previously). This looks just fine. I'll merge and credit both you and ghost ;)

@wtoorop wtoorop merged commit d6b2ca8 into NLnetLabs:develop Aug 27, 2024
1 of 8 checks passed
wtoorop added a commit that referenced this pull request Aug 27, 2024
@wtoorop
Credit tgreenx for #246 and #247
b398138
@tgreenx tgreenx mentioned this pull request Aug 27, 2024
Merged
@tgreenx tgreenx deleted the cdnskey_calc_keytag branch August 27, 2024 12:17
@tgreenx tgreenx mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgreenx @wtoorop