Skip to content

Commit

Permalink
Merge pull request #29 from NVIDIA-ISAAC-ROS/release-3.2
Browse files Browse the repository at this point in the history
Improve input validation
  • Loading branch information
jaiveersinghNV authored Jan 31, 2025
2 parents 4712de6 + c1f66b5 commit d429529
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ NVIDIA accelerated packages for arm motion planning and control

## Overview

[Isaac ROS cuMotion](https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_cumotion) provides CUDA-accelerated manipulation
Isaac ROS cuMotion provides CUDA-accelerated manipulation
capabilities for robots in ROS 2. It provides two main capabilities:

1. Motion generation for robot arms via integration of [cuMotion](https://nvidia-isaac-ros.github.io/concepts/manipulation/index.html#concept-cumotion)
Expand Down
7 changes: 7 additions & 0 deletions isaac_ros_cumotion/isaac_ros_cumotion/cumotion_planner.py
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,13 @@ def execute_callback(self, goal_handle):
joint_names=self.__js_buffer['joint_names'],
)
state.velocity = self.tensor_args.to_device(self.__js_buffer['velocity']).unsqueeze(0)
if state.velocity.shape != state.position.shape:
self.get_logger().error(
'start joint position shape is ' + str(state.position.shape) +
' start velocity shape is ' + str(state.velocity.shape) +
', both should match. JointState was read from ' + self.__joint_states_topic
)
return result
current_joint_state = self.motion_gen.get_active_js(state)
if start_state is not None and plan_req.start_state.is_diff:
start_state.position += current_joint_state.position
Expand Down
1 change: 1 addition & 0 deletions isaac_ros_cumotion/params/isaac_ros_cumotion_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
num_trajopt_seeds: 6
include_trajopt_retract_seed: True
num_trajopt_time_steps: 32
joint_states_topic: "/joint_states"
interpolation_dt: 0.025
collision_cache_cuboid: 20
collision_cache_mesh: 20
Expand Down

0 comments on commit d429529

Please sign in to comment.