-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-function support to FlatIR and stablehlo #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
4 times, most recently
from
September 3, 2024 03:40
383a933
to
8bb43ab
Compare
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
11 times, most recently
from
September 9, 2024 20:01
f1181c4
to
07c164e
Compare
parthchadha
reviewed
Sep 9, 2024
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
from
September 9, 2024 21:20
07c164e
to
e5a8907
Compare
jhalakpatel
commented
Sep 9, 2024
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
3 times, most recently
from
September 10, 2024 01:21
811c458
to
b944abf
Compare
jhalakpatel
changed the title
Add flat ir function
Add mulit function support to FlatIR and stablehlo
Sep 10, 2024
jhalakpatel
commented
Sep 10, 2024
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
from
September 10, 2024 20:24
b944abf
to
9d5658c
Compare
pranavm-nvidia
changed the title
Add mulit function support to FlatIR and stablehlo
Add multi-function support to FlatIR and stablehlo
Sep 11, 2024
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
11 times, most recently
from
September 27, 2024 19:35
2d612b8
to
9d36ff8
Compare
parthchadha
reviewed
Sep 30, 2024
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
5 times, most recently
from
October 2, 2024 21:25
bbb44fa
to
353fd30
Compare
pranavm-nvidia
approved these changes
Oct 2, 2024
jhalakpatel
force-pushed
the
jhalakp-multi-func
branch
from
October 2, 2024 23:02
353fd30
to
95c6354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #155
Major changes:
wraps_to_flat_ir_to_func
which wraps flat ir operations defined into_flat_ir
method of a trace operation.FlatIRFunction
class to represent a Flat IR function.integrate_subgraph
to iteratively add nested ops in a function. Rebind function inputs/outputs.to_mlir_impl
method to add function ops. Add logic to fix up function input and result type due to type resolution inop.to_mlir
.Before:
After:
Function deduplication:
Slice
is called 10 times in the below main function.FlatIR:
StableHLO: