Add outer product implementation #213
Open
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilg-nv
force-pushed
the
dev-akhilg-outer-product
branch
from
e5aa6af
to
d5851bd
Compare
|
I've modified the implementation to use matrix multiply rather than element-wise multiply even though they behave the same for the unsqueezed 1-d vectors, since it's more conceptually natural. |
akhilg-nv
force-pushed
the
dev-akhilg-outer-product
branch
from
d5851bd
to
d5393c3
Compare
parthchadha
reviewed
Sep 20, 2024
|
|
||
| from tests import helper | ||
| import tripy as tp | ||
| class TestOuter: |
There was a problem hiding this comment.
Do you plan to add integration tests?
There was a problem hiding this comment.
I wasn't sure what case to test other than what's in the docstring and this frontend test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.