Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stablehlo pad converter #215

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Fix stablehlo pad converter #215

merged 3 commits into from
Sep 24, 2024

Conversation

yizhuoz004
Copy link
Collaborator

No description provided.

@christopherbate
Copy link
Collaborator

Thanks. Just needs test in test/Conversion/StablehloToTensorRT/stablehlo-to-tensorrt.mlir. There are several stablehlo.pad conversions tests but looks like they are missing a case for non-zero "low-padding".

@yizhuoz004
Copy link
Collaborator Author

Thanks. Just needs test in test/Conversion/StablehloToTensorRT/stablehlo-to-tensorrt.mlir. There are several stablehlo.pad conversions tests but looks like they are missing a case for non-zero "low-padding".

Added the non-zero "low-padding" test. Thanks!

@yizhuoz004 yizhuoz004 merged commit a78330a into main Sep 24, 2024
1 check passed
@yizhuoz004 yizhuoz004 deleted the dev-yizhuoz-fix-pad-converter branch September 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavm-nvidia pranavm-nvidia pranavm-nvidia approved these changes

@christopherbate christopherbate Awaiting requested review from christopherbate christopherbate is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yizhuoz004 @christopherbate @pranavm-nvidia