Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow state synthesis for remote simulators #2212

Merged
merged 18 commits into from
Sep 19, 2024
Merged

Allow state synthesis for remote simulators #2212

merged 18 commits into from
Sep 19, 2024

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Sep 12, 2024 •
edited
Loading

Description

Allow state synthesis for remote simulators.

  • Copy pointers that we save in remote simulation state, to avoid them being overridden by other code.
  • Add tests for lazy evaluation with state pointers
  • Add trotter test on remote simulators.

Note: do not enable the trotter_kernel_mode.cpp yet as it requires using new synthesis on remote platform.

Requires: #2211
Closes: #2210

@annagrin annagrin marked this pull request as draft September 12, 2024 21:48
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@cuda-quantum-bot
Docs preview for PR #2212.
40febab
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@cuda-quantum-bot
Docs preview for PR #2212.
54bf7fb
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@annagrin annagrin marked this pull request as ready for review September 17, 2024 22:33
1tnguyen
1tnguyen approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks, @annagrin!

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
@cuda-quantum-bot
Docs preview for PR #2212.
809e463
schweitzpgi
schweitzpgi approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@annagrin annagrin enabled auto-merge (squash) September 18, 2024 18:27
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
@cuda-quantum-bot
Docs preview for PR #2212.
8b20270
@annagrin annagrin merged commit 67b74c1 into NVIDIA:main Sep 19, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trotter example not running on remote simulators
3 participants
@annagrin @schweitzpgi @1tnguyen