VertexArrayObject fix for gl 3.3 #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: operel <[email protected]> Extra robustness to missing gl / cugl features Signed-off-by: operel <[email protected]>
orperel
force-pushed
the
operel/gl_vao_fix
branch
from
233cd80
to
12a7239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WispApp uses glumpy with a
glfw_imguibackend, which defaults to OpenGL 2.1 context. However, imgui expects an OpenGL 3.3+ context, which causes errors on some envs.glumpy.app.configuration.get_default(), which effectively takes the correct GL version we put in theWispStateconfig (the previous MR usedapp.configuration.Configuration(), this is not enough).WispAppnow ensures there is a default VAO in place.See also: glumpy/glumpy#310
In addition, the following changes add some extra robustness:
3. World grid gizmo try-except extended to catch more errors in case
GL_TEXTURE_MAX_ANISOTROPYis missing from the feature set.4.
_register_cugl_shared_texturewill now fallback toblitdevice2device=False(WSL mode) if cugl registration failed.Signed-off-by: operel [email protected]