Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model replication issue when using PointNet2SetAbstraction with nn.DataParallel #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acivgin1
Copy link

@acivgin1 acivgin1 commented Aug 24, 2020

When using nn.DataParallel, modules registered inside PointNet2SetAbstraction's self.sub_modules are replicated to different devices, and the objects (tuple of grouper, pointnet, num_samples) in self.layers remain on the first device. This causes issues when working with nn.DataParallel.

This fix removes the helper attribute of self.layers and directly uses the submodules registered with nn.ModuleList in the forward pass.

@acivgin1 acivgin1 force-pushed the master branch 4 times, most recently from be39fd7 to 4c4e009 Compare August 24, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants