Encode SlaSpace wordsize as an unsigned integer #6631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborgerson
force-pushed
the
fix/slaspace-wordsize-type
branch
from
31ab375
to
fb3c9a7
Compare
mborgerson
changed the title
mborgerson
force-pushed
the
fix/slaspace-wordsize-type
branch
from
fb3c9a7
to
30d660a
Compare
mborgerson
changed the title
This patch corrects a mismatch between the encoder and decoder in wordsize signedness. AddrSpace::getWordSize() returns an unsigned integer, so use unsigned here for consistency.
mborgerson
force-pushed
the
fix/slaspace-wordsize-type
branch
from
30d660a
to
dc8bebe
Compare
ryanmkurtz
added
Feature: Decompiler
Status: Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corrects a mismatch between the encoder and decoder in wordsize signedness.
AddrSpace::getWordSize()returns an unsigned integer, so use unsigned here for consistency.Fixes loading SLA files for: