Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore multiple references of components / version pattern change #10

Closed
wants to merge 1 commit into from
Closed

Conversation

udondan
Copy link

@udondan udondan commented Oct 10, 2014

  • In case a bootstrap component is references multiple times within multiple *bootstrap.json files, it's still only added once. Merging support for multiple config files #8
  • Change version pattern to better see which version of bootstrap is shipped. Package version #9 (I hope it's possible to publish it with this lowered version number)

Only add each component once to avoid duplicate code.
@Nemo64
Copy link
Owner

Nemo64 commented Oct 10, 2014

Good idea, however there are some edge cases that aren't handled. It must be possible to edit the variable file custom.bootstrap.import.less. I assume that it isn't possible like that as you have your own import.less with variables in the package then. This would mean that if I edit variables, I'd have different custom versions of bootstrap mixed together.

Maybe there needs to be another kind of json file that does not generate anything but adds modules to the compilation at the end. I currently think about something like a package.bootstrap.json or similar. One problem with that though is that the developer at the end MUST create his own custom.bootstrap.json in order for the final files to be generated.

@Nemo64 Nemo64 closed this Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants