Update all fields on AdvisorData upsert #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricksanders
force-pushed
the
fix/upsert-bug
branch
from
75e9a86 to
321f630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the IAM Last Accessed Info data may reflect a new
LastAuthenticatedtimestamp before being updated withLastAuthenticatedEntityandTotalAuthenticatedEntities. If Aardvark's updater runs between those two events, subsequent updater runs will not update the database record withLastAuthenticatedEntityandTotalAuthenticatedEntities. This happens becauseAdvisorData.create_or_update()only updates the database record when the newLastAuthenticatedis greater than the existing record (or zero, sometimes). And even when the timestamp increases, only the timestamp ends up getting updated in the database.This PR updates the implementation so that all fields are updated in the model. SQLAlchemy will ignore any records whose values have not been modified, meaning that we shouldn't see a meaningful increase on database load with this change.
I also added some tests to validate these changes, which was the most difficult part of the whole ordeal. I was able to do so without too much noise, with the exception of needing to add support for config overrides in the
create_app()function.