refactor: always set the server address on service connection pool #781
Conversation
|
I think this may not be correct. The per-server connection pool should probably be torn down and recreated when the address changes. |
|
I thought about that possibility as well but didn't test it. I will refactor it and test the effect. |
hermanyglauber
force-pushed
the
set-server-addr
branch
2 times, most recently
from
2403720
to
1c53647
Compare
hermanyglauber
force-pushed
the
set-server-addr
branch
from
1c53647
to
d691f97
Compare
|
Just FYI, this may be a bigger piece of work than you want to bite off. I think the pool needs to be closed (witch existing requests being allowed to finish). This will be tough to test. |
|
FYI, those changes have been deployed in 6 different environments in a custom zuul-core version. Performance test has been done, there was no degradation in the resources utilization, neither in latency and neither in error rate, in fact, the number of request with 5xx status decreased and so did retries. Most likely the in progress connections are going to fail as the backend will not be connectable via old IP, do you agree? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Logic to avoid DNS/IP address caching on perServerConnectionPool that causes 502 Bad Gateway error connecting to the Origin endpoint. Issue described on #780