zuul-core: Default worker pool size to 2 * processor count #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argha-c
changed the title
artgon
reviewed
Jun 16, 2020
| @@ -33,7 +33,7 @@ | |||
|
|
|||
| public DefaultEventLoopConfig() | |||
| { | |||
| eventLoopCount = WORKER_THREADS.get() > 0 ? WORKER_THREADS.get() : PROCESSOR_COUNT; | |||
| eventLoopCount = WORKER_THREADS.get() > 0 ? WORKER_THREADS.get() : Math.max(8, PROCESSOR_COUNT*2); | |||
There was a problem hiding this comment.
max is actually the minimum here.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my past experience with Netty, at reasonable scale, a conservative but sane default has been to set the worker pool to 2x the virtual CPU.
This PR sets a ceiling of
8(arguably, a magic number), but more importantly, doubles the worker pool for anything running on lower than 4 cores.We obviously need to run benchmarks on this, but I believe this is worth reconsidering.