Add ladybird.rb formula

[Neved4]

Any PRs to build this welcome!

[0risc]

As far as I can tell Ladybird doesn't provide any precompiled builds yet so this would have to be a formula rather than a cask. Spent a few minutes on it but it looks like it'll be fairly complicated to build.

Worth considering whether it's appropriate for a brew formula at this time LadybirdBrowser/ladybird#25 (comment)

Also seems like you've got some extraneous commits in here.

Please do the following:

1. Move it to the formulas folder
2. Fix the style issues (tabs instead of spaces, wrong indentation)
3. Make it actually build (seemingly will need more dependencies and possibly more build commands. not 100% sure what changes will be required. I messed with it for a while and couldn't get it to build)
4. You may want to get rid of the extraneous commits that change README.md in unrelated ways

[Neved4]

This was a typo, meant to close a different PR.

[Neved4]

@0risc

• Fixed most brew style issues
• Solved README.md conflicts

[Neved4]

We'd appreciate any outside help to build Ladybird 🤍

[Neved4]

For reference, the Nix package contains some build steps.

[Neved4]

There's been some progress and got rid of some of the errors when building it.

Currently fails with:

CMake Error at /opt/homebrew/Cellar/cmake/3.30.4/share/cmake/Modules/FindPkgConfig.cmake:645 (message):
  The following required packages were not found:

   - skia=129
   - skia

Ladybird uses Skia for rendering SVG and 2D canvas.

Right now google/skia is not available in homebrew-core, so we might need to package it to build Ladybird.

[Neved4]

Decided to take a different approach using the steps from BuildInstructionsLadybird.md, namely:

brew install autoconf autoconf-archive automake ccache cmake ffmpeg nasm ninja pkg-config llvm

CC=$(brew --prefix llvm)/bin/clang CXX=$(brew --prefix llvm)/bin/clang++ ./Meta/ladybird.sh build

[Neved4]

Ladybird seems to be building, but we need to move the resulting .app to /Applications.

[tostr7191]

I installed the current ladybird.rb, and afterwards I get this:

$ ladybird 
dyld[39746]: Library not loaded: @rpath/liblagom-webview.0.dylib
  Referenced from: <7D37594E-D72D-3B29-81F9-636CCB53232B> /opt/homebrew/Cellar/ladybird/0.1.0-b9e7c6a/Ladybird.app/Contents/MacOS/Ladybird
  Reason: tried: '/opt/homebrew/Cellar/ladybird/0.1.0-b9e7c6a/Ladybird.app/Contents/lib/liblagom-webview.0.dylib' (no such file), '/opt/homebrew/Cellar/ladybird/0.1.0-b9e7c6a/Ladybird.app/Contents/lib/liblagom-webview.0.dylib' (no such file)
fish: Job 1, 'ladybird' terminated by signal SIGABRT (Abort)

The directory /opt/homebrew/Cellar/ladybird/0.1.0-b9e7c6a/Ladybird.app/Contents/lib/ does, in fact, not exist. The buildscript did finish without any reported issues however.

[Neved4]

Hey @tostr7191 thx for trying this out!

Wasn't advancing with it personally, so I assigned it to @0risc.

We'd love any help to push this forward!

[tostr7191]

@Neved4 thanks for you words, I am not really knowledgeable about this subject unfortunately. But I did try to run the steps in the formula by hand, and - lo and behold - I get a functioning .app file in the build directory.

Upon further inspection, the problem seems to come from the lib in the app bundle being symlinked, but getting cleaned up by brew, which breaks the link.

I have changed the formula a bit, an now it builds a functioning .app bundle on my system, I would be grateful if someone could verify it. The main change is ln29-32, which replaces the lib symlink with the actual directory.

Formula follows, if it works I can create a proper pull request.

class Ladybird < Formula
  desc "Truly independent web browser (pre-alpha developer version)"
  homepage "https://ladybird.org/"
  url "https://github.com/LadybirdBrowser/ladybird/archive/b9e7c6a2f66d83c6af73bcc102c05d3056382c02.tar.gz"
  version "0.1.0-b9e7c6a"
  sha256 "855a293849805d89c49cc29fd87a6b3e002f68d633f7ce52065e3260046be54b"
  license "BSD-2-Clause"
  head "https://github.com/LadybirdBrowser/ladybird.git", branch: "master"

  depends_on "autoconf" => :build
  depends_on "autoconf-archive" => :build
  depends_on "automake" => :build
  depends_on "ccache" => :build
  depends_on "cmake" => :build
  depends_on "ffmpeg" => :build
  depends_on "llvm" => :build
  depends_on "nasm" => :build
  depends_on "ninja" => :build
  depends_on "pkg-config" => :build
  depends_on :macos

  def install
    ENV["CC"] = "#{Formula["llvm"].opt_bin}/clang"
    ENV["CXX"] = "#{Formula["llvm"].opt_bin}/clang++"

    system "git", "init"
    system "./Meta/ladybird.sh", "install"

    cd "Build/ladybird/bin/Ladybird.app/Contents" do
      system "unlink", "./lib"
      system "cp", "-r", "../../../lib", "."
    end

    app_name = "Ladybird.app"
    app_path = "./Build/ladybird/bin/#{app_name}"

    prefix.install app_path
    bin.install_symlink "#{prefix}/#{app_name}/Contents/MacOS/Ladybird" => "ladybird"
    #bin.install_symlink "#{prefix}/#{app_name}" => "/Applications/"
  end

  def caveats
    <<~EOS
      Ladybird is in pre-alpha stage and is intended for developers only.
    EOS
  end
end

[Neved4]

@tostr7191 Woa thx a lot 🚀 LGTM! Added you as a Co-Author in the commit!

Also changed those system calls to more idiomatic ones to placate brew style.

[Neved4]

@tostr7191 Apparently some runners are failing, lmk if u can take a look: step:7:55

[ADKaster]

Using vcpkg inside a brew formula is strange. I would expect that upstream would only accept a formula if you use other homebrew packages to obtain the dependencies.

[Neved4]

Hey @ADKaster thx I think you're right!

Do you have any improvements we could add?

Cheers