Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem: ByNamePackagePrefixedWithNumber #122

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
treefmt
Ben-PH committed Oct 29, 2024
commit 7f3e6ce7b32c6aa1635059863fb31e702e61c229
3 changes: 2 additions & 1 deletion tests/by-name-numprefix/pkgs/by-name/_1/10foo/package.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to think about is how users are likely to run into a problem. Since users will know that the first two chars of the shard need to match the attribute name, _1/10foo is rather unlikely, so instead it's better to make sure it triggers on 10/10foo.

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{ someDrv }: SomeDrv
{ someDrv }:
SomeDrv
# If we caused an actual Nix failure
# builtins.trace "This should be on stderr!" throw "This is an error!"