-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add problem: ByNamePackagePrefixedWithNumber #122
Open
Ben-PH
wants to merge
12
commits into
NixOS:main
Choose a base branch
from
Ben-PH:107_by-name-num-prefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−8
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5006491
Initial #107 work
Ben-PH 85a1b53
Update shard/package name sanatisation regex
Ben-PH af703c9
Add test
Ben-PH fd4a72f
cargo fmt
Ben-PH e693e74
Rename dir: 10 -> _1
Ben-PH 884c807
add leading digit check
Ben-PH 05bafef
Cleanup err-msg and match(ish) it with expected
Ben-PH c20b06e
Remodel test based on invalid name test
Ben-PH 7f3e6ce
treefmt
Ben-PH 932f6ef
Review followup
Ben-PH 837cba7
Fix CI error
Ben-PH 2e54489
Update README
Ben-PH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
treefmt
commit 7f3e6ce7b32c6aa1635059863fb31e702e61c229
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ someDrv }: SomeDrv | ||
{ someDrv }: | ||
SomeDrv | ||
# If we caused an actual Nix failure | ||
# builtins.trace "This should be on stderr!" throw "This is an error!" | ||
willbush marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to think about is how users are likely to run into a problem. Since users will know that the first two chars of the shard need to match the attribute name,
_1/10foo
is rather unlikely, so instead it's better to make sure it triggers on10/10foo
.