Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to run in debug mode #390

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ErwanRaulo
Copy link
Contributor

No description provided.

@PierreDemailly PierreDemailly linked an issue Jul 16, 2024 that may be closed by this pull request
@ErwanRaulo
Copy link
Contributor Author

Execute function become too big, I propose to put Rc.read and folder creation in an init function.

@fraxken
Copy link
Member

fraxken commented Jul 16, 2024

Execute function become too big, I propose to put Rc.read and folder creation in an init function.

Doesn't bother me that much (that's quite common in CLI). Spliting with no improvement on how we abstract the implementation is quite useless and just make things harder to maintain later.

@ErwanRaulo ErwanRaulo marked this pull request as draft July 16, 2024 22:21
@ErwanRaulo ErwanRaulo requested a review from fraxken July 16, 2024 22:22
@ErwanRaulo ErwanRaulo marked this pull request as ready for review July 16, 2024 22:23
Copy link
Member

@PierreDemailly PierreDemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also document this in the README

@ErwanRaulo ErwanRaulo force-pushed the issue-375 branch 2 times, most recently from 70a7620 to 31b287b Compare July 23, 2024 11:01
* fix: repository name with spaces breaks git clone command
@fraxken fraxken merged commit 573c66b into NodeSecure:master Jul 23, 2024
4 checks passed
@ErwanRaulo ErwanRaulo deleted the issue-375 branch July 23, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI argument to dump data before HTML report
3 participants