Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvmError: Revert in setUp() #6329

Closed
kanej opened this issue Feb 18, 2025 · 0 comments · Fixed by #6332
Closed

EvmError: Revert in setUp() #6329

kanej opened this issue Feb 18, 2025 · 0 comments · Fixed by #6332
Assignees
@galargh
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone
Public Alpha

Comments

@kanej
Copy link
Member

kanej commented Feb 18, 2025

During Solidity Test testing the following error was found in pcaversaccio/createx:

Failure (19): setUp()
Reason: EvmError: Revert
  at ERC20MockPayable.constructor (test/mocks/ERC20MockPayable.sol:14)

We have determined this is because EDR Solidity Test is being passed contracts that are not test contracts.

Eventually we want EDR to be able to detect this, for the moment we are going to filter out the passed in artifacts based on ABI.
@kanej kanej added the v-next A Hardhat v3 development task label Feb 18, 2025
@kanej kanej added this to the Public Alpha milestone Feb 18, 2025
@kanej kanej added this to Hardhat Feb 18, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Feb 18, 2025
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 18, 2025
@kanej kanej moved this from Backlog to In Progress in Hardhat Feb 18, 2025
@kanej kanej linked a pull request Feb 19, 2025 that will close this issue
fix: correctly identify test suites #6332
Merged
3 tasks
@kanej kanej closed this as completed Feb 19, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hardhat Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galargh galargh

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: Done
Milestone
Public Alpha
Development

Successfully merging a pull request may close this issue.

fix: correctly identify test suites NomicFoundation/hardhat
2 participants
@kanej @galargh