-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly identify test suites #6332
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for this PR!
I can confirm that it fixes these errors in forge-std
:
Ran 1 tests for test/StdCheats.t.sol:MockContractWithConstructorArgs (v0.8.26)
✘ Failed(1): setUp() (duration: 0 ms, consumedGas: 0)
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)
Ran 1 tests for test/StdAssertions.t.sol:TestMockCall (v0.8.26)
✘ Failed(2): setUp() (duration: 0 ms, consumedGas: 0)
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)
Ran 1 tests for test/StdStorage.t.sol:StorageTestTarget (v0.8.26)
✘ Failed(3): setUp() (duration: 0 ms, consumedGas: 0)
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)
Ran 1 tests for test/StdCheats.t.sol:RevertingContract (v0.8.26)
✘ Failed(4): setUp() (duration: 0 ms, consumedGas: 0)
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This resolves https://www.notion.so/nomicfoundation/Public-Alpha-Solidity-Test-Comparison-19d578cdeaf58070a453c4059f3df4dd?pvs=4#19d578cdeaf5803da9f0ddc5b4a3ca20
This was tested in https://github.com/galargh/solidity-testing-testing/actions/runs/13395288956/job/37412700270
The output no longer contains
EvmError: Revert in setUp()
errors in constructors.