Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly identify test suites #6332

Merged
merged 3 commits into from
Feb 18, 2025
Merged

fix: correctly identify test suites #6332

merged 3 commits into from
Feb 18, 2025

Conversation

galargh
Copy link
Member

@galargh galargh commented Feb 18, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This resolves https://www.notion.so/nomicfoundation/Public-Alpha-Solidity-Test-Comparison-19d578cdeaf58070a453c4059f3df4dd?pvs=4#19d578cdeaf5803da9f0ddc5b4a3ca20

This was tested in https://github.com/galargh/solidity-testing-testing/actions/runs/13395288956/job/37412700270

The output no longer contains EvmError: Revert in setUp() errors in constructors.

@galargh galargh requested review from kanej and alcuadrado February 18, 2025 16:27
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:22pm

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 81cae17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 18, 2025
@galargh galargh requested a review from agostbiro February 18, 2025 16:27
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this PR!

I can confirm that it fixes these errors in forge-std:


Ran 1 tests for test/StdCheats.t.sol:MockContractWithConstructorArgs (v0.8.26)
✘ Failed(1): setUp() (duration: 0 ms, consumedGas: 0)                                        
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)
                                                                   
Ran 1 tests for test/StdAssertions.t.sol:TestMockCall (v0.8.26)                              
✘ Failed(2): setUp() (duration: 0 ms, consumedGas: 0)                                
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)                      
                                                                                             
Ran 1 tests for test/StdStorage.t.sol:StorageTestTarget (v0.8.26)                       
✘ Failed(3): setUp() (duration: 0 ms, consumedGas: 0)                                        
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)                      
                                                                                             
Ran 1 tests for test/StdCheats.t.sol:RevertingContract (v0.8.26)                             
✘ Failed(4): setUp() (duration: 0 ms, consumedGas: 0)                                        
✘ Suite Failed: 1 tests, 0 passed, 1 failed, 0 skipped (duration: 0 ms)                      

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@galargh galargh enabled auto-merge February 18, 2025 18:21
@galargh galargh added this pull request to the merge queue Feb 18, 2025
Merged via the queue into v-next with commit 60426f8 Feb 18, 2025
75 checks passed
@galargh galargh deleted the test-suites branch February 18, 2025 18:33
@kanej kanej linked an issue Feb 19, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

EvmError: Revert in setUp()
3 participants