Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] survey_next_survey_update_partner: new module #115

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

chienandalu
Copy link
Member

This module acts as a bridge of survey_contact_generation and survey_answer_generation so
when we link contact generation questions, the values that change in the next survey update
those of the created partner.

pending:

cc @Tecnativa TT47575

@chienandalu chienandalu force-pushed the 15.0-add-survey_next_survey_update_partner branch from 0c7f3b8 to a5c0c9d Compare February 26, 2024 14:29
@pedrobaeza pedrobaeza added this to the 15.0 milestone Mar 7, 2024
@chienandalu chienandalu force-pushed the 15.0-add-survey_next_survey_update_partner branch 2 times, most recently from de4de1a to a886226 Compare March 14, 2024 08:55
@chienandalu chienandalu force-pushed the 15.0-add-survey_next_survey_update_partner branch from a886226 to 495015f Compare May 24, 2024 07:05
@arielbarreiros96
Copy link

arielbarreiros96 commented Dec 18, 2024

@chienandalu I was reviewing this workflow, and while it is quite interesting that the answers are pre-filled from the beginning. Wouldn't it be interesting to add this update feature directly in survey_contact_generation and keep this two features separate as they are now?
At the moment this module (survey_contact_generation ) has the generate_contact field, there could be for instance an update_contact field that checks if it will be possible to update or not, and if there is a contact with the same email then update it.
In this method you already do all the checks and create the contact, from here it should not be too complicated to update the existing partner.
I would appreciate your thoughts on this, does it make sense to you? Thanks in advance

@chienandalu
Copy link
Member Author

Hi @arielbarreiros96 the thing is that updating the contact makes no sense in a regular workflow without linked surveys. Just here, where we have a subsequent survey which answers are linked to the original one that generated a brand new contact...

Not the cleanest workflow... but it's our customer's requirements... 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants