Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] web_responsive: resign as maintainer #2696

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

yajo
Copy link
Member

@yajo yajo commented Dec 18, 2023

No description provided.

@yajo yajo self-assigned this Dec 18, 2023
@OCA-git-bot
Copy link
Contributor

Hi @SplashS, @Tardo, @yajo,
some modules you are maintaining are being modified, check this out!

@yajo yajo added this to the 16.0 milestone Dec 18, 2023
@yajo
Copy link
Member Author

yajo commented Dec 18, 2023

fast-tracking

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2696-by-yajo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2a12301 into OCA:16.0 Dec 18, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d66d561. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

@yajo yajo deleted the 16.0-web_responsive-yajo_out branch December 18, 2023 08:36
@yajo
Copy link
Member Author

yajo commented Dec 18, 2023

Sorry, I got confused with conventional commits, which I'm more used to lately. In any case, I don't see any commit tag that fits this kind of change.

@pedrobaeza
Copy link
Member

It's true that this doesn't fit in any of the existing one, but [BUILD] doesn't seem also the best one. We can propose to add one. Suggestions? I think in [CONF], [MANT] or [OCA].

@yajo
Copy link
Member Author

yajo commented Dec 18, 2023

In the world of conventional commits you'd use docs, chore or build. The standard is based on the one pioneered by AngularJS, and they removed chore in 2017 because it was often abused (conventional-commits/conventionalcommits.org#303).

I think we can stick with [BUILD] (after all, changes on maintainership affect to the development cycle, which is generally a good fit for [BUILD]) or [CHORE].

@pedrobaeza
Copy link
Member

For me that's counter-intuitive, but if others see it natural, no special problem for me.

@simahawk
Copy link
Contributor

FWIW to me is just an "update". Nothing more. Don't get too complicated w/ these tags guys! 😄

@pedrobaeza
Copy link
Member

[UPD] is also a non valid tag according current guidelines.

davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
Signed-off-by yajo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants