Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] web_notify html format #2697

Merged
merged 1 commit into from
Jan 6, 2024
Merged

[15.0][IMP] web_notify html format #2697

merged 1 commit into from
Jan 6, 2024

Conversation

hhgabelgaard
Copy link
Contributor

In v12 the message was rendered as HTML
This restore that as an option

@hhgabelgaard hhgabelgaard changed the title 15.0 issue46678 web notify html format hhg [15.0][IMP] web_notify html format Dec 18, 2023
@hhgabelgaard hhgabelgaard force-pushed the 15.0-issue46678-web_notify-html-format-hhg branch from 4984fd7 to 196818e Compare December 18, 2023 18:38
chienandalu
chienandalu suggested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase your branch so you have only your PR commit

@hhgabelgaard
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @hhgabelgaard you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@hhgabelgaard hhgabelgaard force-pushed the 15.0-issue46678-web_notify-html-format-hhg branch from 196818e to 7f3755a Compare December 30, 2023 14:41
@hhgabelgaard hhgabelgaard force-pushed the 15.0-issue46678-web_notify-html-format-hhg branch from 7f3755a to 159f732 Compare December 30, 2023 14:49
@hhgabelgaard
Copy link
Contributor Author

@chienandalu branch rebased

chienandalu
chienandalu approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jan 2, 2024
Bilbonet
Bilbonet approved these changes Jan 6, 2024
View reviewed changes
Copy link

@Bilbonet Bilbonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not start, because command git fetch --quiet --force --prune https://github.com/OCA/web 'refs/heads/*:refs/heads/*' failed with output:

fatal: unable to access 'https://github.com/OCA/web/': gnutls_handshake() failed: The TLS connection was non-properly terminated.

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2697-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f82258c into OCA:15.0 Jan 6, 2024
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 95b9199. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@Bilbonet Bilbonet Bilbonet approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hhgabelgaard @OCA-git-bot @pedrobaeza @chienandalu @Bilbonet