Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix tests that were actually not testing anything #4349

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

petrasovaa
Copy link
Contributor

I am trying to revise the dataset used in tests with the goal of creating a new dedicated test dataset based on the nc spm basic dataset. Right now the tests use the combination of both basic and full dataset. As part of this I fixed many tests that didn't make any sense and were not testing anything.

There will be more, but this is already enough to review.

@petrasovaa petrasovaa added this to the 8.5.0 milestone Sep 19, 2024
@petrasovaa petrasovaa self-assigned this Sep 19, 2024
@github-actions github-actions bot added vector Related to vector data processing Python Related code is in Python module tests Related to Test Suite labels Sep 19, 2024
@petrasovaa petrasovaa marked this pull request as draft September 20, 2024 02:11
@echoix
Copy link
Member

echoix commented Sep 20, 2024

I know it's not exactly related, but you might be interested to know that. I'm really near to have finished adding a new decorator for setting expected failures to all failing test functions (not files) on Windows. Then I will be able to set the Windows tests to require all tests passing. When tests are unexpected successes, we'll know, and if it is caused by a real fix, we remove the decorator and that test cannot fail again.

I'm only a couple days away from it, as I don't know exactly what to do with straight up errors in the setup class, and still need to review if my last round of adding decorators handles all of the failing tests.

We shouldn't be stepping on our foots, but you might still want to be aware of it.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need an update from main at this point, but otherwise that's good to go.

vector/v.select/testsuite/test_v_select.py Show resolved Hide resolved
@petrasovaa petrasovaa changed the title tests: fix tests and use layers from nc_spm_basic dataset tests: fix tests that were actually not testing anything Oct 1, 2024
@petrasovaa petrasovaa merged commit ed10037 into OSGeo:main Oct 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Python Related code is in Python tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants