Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi threat libs #263

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Multi threat libs #263

wants to merge 8 commits into from

Conversation

izar
Copy link
Collaborator

@izar izar commented Feb 20, 2025

Adds capability to select which threat lib to use on the command line:

  • nothing in the command line: uses the default library
  • --threat-files foo.json : uses the threats in foo.json only
  • --threat-files foo.json default : uses the threats in foo.json and the default ones

@izar izar requested a review from colesmj February 20, 2025 20:01
@@ -1405,5 +1405,5 @@
"name": "my test tm",
"onDuplicates": "Action.NO_ACTION",
"threatsExcluded": [],
"threatsFile": "pytm/threatlib/threats.json"
"threatsFile": "{'pytm/threatlib/threats.json'}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the output a string and not a list of strings?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what varStrings with only one value put out...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the immortal words of just about everybody..."works for me"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants