-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let user input OpenAI keys in F5 #13130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #13130 +/- ##
========================================
Coverage 90.28% 90.28%
========================================
Files 583 584 +1
Lines 35061 35185 +124
Branches 6834 6849 +15
========================================
+ Hits 31654 31766 +112
- Misses 1478 1484 +6
- Partials 1929 1935 +6
|
jayzhang
reviewed
Feb 6, 2025
nliu-ms
requested review from
swatDong,
XiaofuHuang,
xiaolang124,
kuojianlu,
kimizhu,
wenytang-ms,
Siglud,
xzf0587,
LongOddCode,
yuqizhou77,
tecton,
hund030,
timngmsft,
sffamily,
therealjohn and
supkasar
as code owners
February 8, 2025 02:15
jayzhang
approved these changes
Feb 8, 2025
kuojianlu
approved these changes
Feb 8, 2025
sffamily
approved these changes
Feb 8, 2025
hermanwenhe
pushed a commit
to hermanwenhe/TeamsFx
that referenced
this pull request
Feb 11, 2025
* feat: let user input OpenAI keys in F5
hermanwenhe
pushed a commit
to hermanwenhe/TeamsFx
that referenced
this pull request
Feb 11, 2025
* feat: let user input OpenAI keys in F5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/30664776
We can scaffold OpenAI projects without OpenAI key, but it will meet MissingEnvironmentVariablesError when F5.
In this scenario, we will let user input these env variables to proceed, otherwise it will return a UserCancel error:
If user
Escape
the input:Sample telemetry for UserCancel: