Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: default view #13136

Merged
merged 4 commits into from
Feb 7, 2025
Merged

refactor: default view #13136

merged 4 commits into from
Feb 7, 2025

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented Feb 7, 2025

  • Since we are going to enable such UI in both prerelease and stable, change the default view to be the one with GitHub Copilot so that the loading state can still show the final correct view. It is still possible we will hide it behind feature flag later, so try to make the change the small rather than completely delete the old view.
  • update images. (more will come in later PRs)

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (91653fb) to head (9d32428).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #13136   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         584      584           
  Lines       35126    35126           
  Branches     6945     7033   +88     
=======================================
  Hits        31711    31711           
  Misses       1484     1484           
  Partials     1931     1931           

@yuqizhou77 yuqizhou77 changed the title refactor: update image refactor: default view Feb 7, 2025
@yuqizhou77 yuqizhou77 marked this pull request as ready for review February 7, 2025 04:54
tecton
tecton previously approved these changes Feb 7, 2025
@yuqizhou77 yuqizhou77 merged commit d2d7cd2 into dev Feb 7, 2025
19 checks passed
@yuqizhou77 yuqizhou77 deleted the yuqzho/image branch February 7, 2025 09:04
hermanwenhe pushed a commit to hermanwenhe/TeamsFx that referenced this pull request Feb 11, 2025
* refactor: update image

* refactor: minor

* refactor: minor

* refactor: image
hermanwenhe pushed a commit to hermanwenhe/TeamsFx that referenced this pull request Feb 11, 2025
* refactor: update image

* refactor: minor

* refactor: minor

* refactor: image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants