Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firebase-messaging to 24.0.0 #2149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jul 16, 2024

Description

⚠️ WARNING

This FCM bump requires compileSdkVersion 34, so we may want to defer it until it is more common or find a way to not require it for customers.

One Line Summary

Bump default version of firebase-messaging to 24.0.0.

Details

firebase-messaging has always included play-services-base but in 24.0.0 they changed this to runtime. This means we needed to start including play-services-base in our build.gradle, however we are doing so as compileOnly so we don't upgrade or downgrade the version in the customer's app.

Motivation

We should default the newest tested versions of our dependencies so we get the latest fixes.

Scope

Only upgrading for firebase-messaging.

Testing

Manual testing

Tested on an Android 14 emulator, ensuring it subscribes to FCM and gets a pushToken.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

firebase-messaging has always included play-services-base but in 24.0.0
they changed this to runtime. This means we needed to start including
`play-services-base` in our `build.gradle`, however we are doing so as
`compileOnly` so we don't upgrade or downgrade the version in the customer's
app.
@jkasten2 jkasten2 added the WIP Work In Progress label Jul 16, 2024
Base automatically changed from cleanup-pre-fcm-21-support to main July 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant