WIP: [Feat] Jwt #1178
Open
WIP: [Feat] Jwt #1178
+193
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepherd-l
force-pushed
the
feat/jwt
branch
4 times, most recently
from
db72ea5
to
005e3dd
Compare
Adds jwtToken as a property of OSModel. Removes unused jwtTokenAvailable property from Operation. Removes storing jwtToken in the Database. Since jwtToken is on OSModel, operations can access it from Operation.model.jwtToken and it doesn't need a separate property on Operation.
Removed APIHeaders type as RequestMetadata can be used to create the Jwt header instead. Moved callers passing subscriptionId as a separate parameter and including it in their RequestMetadata parameter instead to utilize RequestMetadata's subscriptionId property (furthering implementation of e5c2a10). Future consideration: add AliasPair to RequestMetadata. Additionally, renamed parameters and method name in OneSignalApiBase for more clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
WIP for adding Jwt identity verification
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is