Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
I've exported the
ConfigurationParameters
from the lib so that it can be reused by dependees.Details
Motivation
I'm wrapping OneSignal in a NestJS configurable module.
For now, the only way to do it is:
Scope
Only TypeScript types are affected.
Other
If possible, please release a new version once this PR gets merged 🙏
Testing
Manual testing
No tests are needed for this PR since this is only a new type export.
Checklist
Overview
Testing
Final pass