Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ConfigurationParameters #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbenoist
Copy link

Description

One Line Summary

I've exported the ConfigurationParameters from the lib so that it can be reused by dependees.

Details

Motivation

I'm wrapping OneSignal in a NestJS configurable module.

For now, the only way to do it is:

export type OneSignalConfigurationParameters = Parameters<
  typeof createConfiguration
>[0];

Scope

Only TypeScript types are affected.

Other

If possible, please release a new version once this PR gets merged 🙏

Testing

Manual testing

No tests are needed for this PR since this is only a new type export.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant