New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing reject for init #139

Open

fehergeri13 wants to merge 1 commit into OneSignal:main from fehergeri13:main

fehergeri13 commented Mar 12, 2024

When I init the oneSignal sdk with some invalid config, I get the following error:

try {
    await OneSignal.init({ appId: "example app id" });
} catch(e) {
    console.log("error with init")
}

Uncaught (in promise) Error: OneSignalSDK: HTTP sites are no longer supported starting with version 16 (User Model), your public site must start with https://. Please visit the OneSignal dashboard's Settings > Web Configuration to find this option.

This is an example error. The main issue is that the error is uncaught.

This PR will fix the uncaught exception


          Fix missing reject for init

ec76244

iAmWillShepherd commented Aug 1, 2024

Thanks for opening the PR. I'll forward this to the team so they can review 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet