added create and delete methods for indices, these should be moved in… #8
Conversation
…to a refactor for CORE.
…asses calling the repos
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Map.Entry; |
There was a problem hiding this comment.
Not a biggie, but I'd rather just use Map.Entry rather than importing it and using it as Entry. We already imported Map.
| public interface ProjectIndex { | ||
|
|
||
| void create(String index) throws IOException; | ||
|
|
There was a problem hiding this comment.
We should also maybe add an update method.
| this.client = client; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Are these overriding anything?
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Component | ||
| public class CommitElasticDAOImpl extends BaseElasticDAOImpl implements CommitIndexDAO { | ||
|
|
||
|
|
||
| public List<Map<String, Object>> findByIndexIds(Set<String> indexIds) { | ||
| return null; |
There was a problem hiding this comment.
Let's start adding TODOs to these so we can find them easier.
… return a empty object
…o. Partial implmentation of timestamp method
| public void deleteAll(String index, Collection<? extends BaseJson> jsons) throws IOException { | ||
| BulkRequest bulkIndex = new BulkRequest(); | ||
| for (BaseJson json : jsons) { | ||
| bulkIndex.add(new DeleteRequest(index, null, json.getId())); |
There was a problem hiding this comment.
json.getIndexId() instead of getId()
| public void indexAll(String index, Collection<? extends BaseJson> jsons) throws IOException { | ||
| BulkRequest bulkIndex = new BulkRequest(); | ||
| for (BaseJson json : jsons) { | ||
| bulkIndex.add(new IndexRequest((index)).source(json)); |
There was a problem hiding this comment.
IndexRequest needs type and id param, add "_doc" and json.getIndexId()
|
|
||
| public void index(String index, BaseJson json) throws IOException { | ||
| client.index(new IndexRequest(index).source(json), RequestOptions.DEFAULT); |
There was a problem hiding this comment.
add "_doc" and json.getIndexId() to IndexRequest
| } | ||
|
|
||
| public void deleteById(String index, String indexId) throws IOException { | ||
| client.delete(new DeleteRequest(index, null, indexId), RequestOptions.DEFAULT); |
There was a problem hiding this comment.
i think all the type arguments still needs an actual type, elastic suggests just use "_doc"
| @Override | ||
| public void create(String index) throws IOException { | ||
| CreateIndexRequest commitIndex = new CreateIndexRequest(index + "_commit"); | ||
| commitIndex.mapping(getCommitMapAsString(), XContentType.JSON); |
There was a problem hiding this comment.
needs the type, use "_doc" as first argument
| } | ||
|
|
||
| private String getCommitMapAsString() { | ||
| return "{\"properties\":{\"added\":{\"properties\":{\"id\":{\"type\":\"keyword\"},\"_indexId\":{\"type\":\"keyword\"},\"type\":{\"type\":\"keyword\"}}},\"updated\":{\"properties\":{\"id\":{\"type\":\"keyword\"},\"_indexId\":{\"type\":\"keyword\"},\"previousIndexId\":{\"type\":\"keyword\"},\"type\":{\"type\":\"keyword\"}}},\"deleted\":{\"properties\":{\"id\":{\"type\":\"keyword\"},\"previousIndexId\":{\"type\":\"keyword\"},\"type\":{\"type\":\"keyword\"}}},\"id\":{\"type\":\"keyword\"},\"_refId\":{\"type\":\"keyword\"},\"_creator\":{\"type\":\"keyword\"},\"_created\":{\"type\":\"date\",\"format\":\"yyyy-MM-dd'T'HH:mm:ss.SSSZ\"},\"_projectId\":{\"type\":\"keyword\"},\"_indexId\":{\"type\":\"keyword\"}}}"; |
There was a problem hiding this comment.
add {"_doc": to the front and } to the back
cleanup create project and bulk get
…to a refactor for CORE.