Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade openapi poms and codegen tests to junit5 #18619

Merged
merged 1 commit into from
May 9, 2024

Conversation

thorstenhirsch
Copy link
Contributor

PR for openapi poms and codegen tests of #18470

@wing328
Copy link
Member

wing328 commented May 9, 2024

lgtm. thanks for the PR

cc @OpenAPITools/generator-core-team

@wing328 wing328 merged commit 5614eef into OpenAPITools:master May 9, 2024
15 of 16 checks passed
@wing328
Copy link
Member

wing328 commented May 9, 2024

outdated doc updated via 98f9c07

@thorstenhirsch thorstenhirsch deleted the codegen branch May 9, 2024 12:51
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
@wing328 wing328 added this to the 7.6.0 milestone May 20, 2024
@wing328
Copy link
Member

wing328 commented May 29, 2024

@thorstenhirsch can you please PM me via Slack about this PR when you've time?

@wing328
Copy link
Member

wing328 commented May 29, 2024

UPDATE: I've reverted this change via #18786 (merged) in the latest master as due to the upgrade, all testng tests were skipped silently (even though there are failed assertions)

I tried various solutions to run both junit5 and testng in the same project but no luck.

My take is to migrate junit4 tests to testng as it would be easier to maintain this project with just one testing framework.

@Philzen
Copy link
Contributor

Philzen commented May 29, 2024

@wing328

all testng tests were skipped silently

i was about to ask about this behavior on slack, as i got the same hunch

I've reverted this change via #18786 (merged) in the latest master

that made me a bit sad when i saw it – as i had the silent hope we'd planning to transition to Junit5 rather than TestNG (oh how i miss the @TempDir annotation which would make many tests so much more concise!) ... also, consumers of v7.6.0 maybe missing the junit5 generation capability that @thorstenhirsch just introduced...

I tried various solutions to run both junit5 and testng in the same project but no luck.

I've tried around a little more and after what felt an eternity was finally successful following https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#How_to_run_TestNG_tests_within_the_JUnit_Platform (using org.junit.support:testng-engine is the key ingredient to ensure the Jupiter test runner picks up the TestNG tests).

I was even able to remove the junit4 dependency from the classpath for good, so one will not be bothered by the org.junit.* stuff in autocompletion (so now there's only two @Test annotations` to choose from instead of three).

See #18790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants