parse out leading exclamations after <at>botname #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Grazfather
reviewed
Feb 9, 2019
|
updated |
|
Nice, less bishop spamming :) |
|
After giving it a try, I don't see any value in this change, since it will only strip an exclamation mark that is following the bot name directly. Not sure, if many people really try to talk to bishop this way. Any other constellation like sup @Bishop what's uuuup?! will still result in an error message (which is totally fine from my point of view) |
|
Closing the pr after talking to @crclark96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parses out leading
!after@botname, issue #157