Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, protocol-designer): fix word break in dropdown menu #17456

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 6, 2025

Overview

According to designs, the main text for a dropdown option should be clamped to 3 lines maximum. In the event that only one option is produced in DropDownStepFormField, the line clamp should also apply to the returned styled text.

Closes RQA-3950

Test Plan and Hands on Testing

  • import or create a protocol with multiple absorbance readers
  • add an absorbance reader-compatible labware with very long name
  • open a reader and move the labware to it
  • create an absorbance reader step and verify that the dropdown menu shows the labware name with absorbance reader, and clamps at 3 lines
Screenshot 2025-02-06 at 12 18 16 PM
  • repeat for a protocol with a single absorbance reader
Screenshot 2025-02-06 at 12 20 54 PM

Changelog

  • fix line clamp style for dropdown option

Review requests

see test plan

Risk assessment

low

This PR fixes word break style for dropdown menu-- should break at word.

Closes RQA-3950
@ncdiehl11 ncdiehl11 requested a review from koji February 6, 2025 21:40
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 6, 2025 21:47
@ncdiehl11 ncdiehl11 requested review from a team as code owners February 6, 2025 21:47
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the case Alex reported and the change worked as expected

@ncdiehl11 ncdiehl11 merged commit 632eb64 into chore_release-pd-8.4.0 Feb 6, 2025
68 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-wordbreak branch February 6, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants