-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdba Adjust methods work in adjust function #480
Open
coxipi
wants to merge
14
commits into
main
Choose a base branch
from
adjust_for_Adjust-Class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_for_Adjust-Class
…t_for_Adjust-Class
Is this PR still relevant? Is it ready for review? @coxipi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
dtrain
inadjust
is optional, you can instead pass amethod
str, to use a biasadjust method that only uses adjustDoes this PR introduce a breaking change?
Not for now. If we would like a more natural ordering or arguments in the
adjust
signature, then we would need some breaking changes (for now I've put the new arguments at the very end of the signature)Other information:
group
needs to be passed inxclim_adjust_args
when using this method. It can be the unparsed group. Is there a problem with this way of doing this? IMO, this is better than having to explicitly passgroup
to the function.I my YAML scripts, I directly put the group in
xclim_train_args
, and I know that those kwargs must be parsed at some point, e.g. becausegroup
comes from a YAML, is not yet a Grouper.