Use xsdba

[coxipi]

Pull Request Checklist:

• This PR addresses an already opened issue (for bug fixes / features)
  • This PR fixes #xyz
• (If applicable) Documentation has been added / updated (for bug fixes / features).
• (If applicable) Tests have been added.
• This PR does not seem to break the templates.
• CHANGELOG.rst has been updated (with summary of main changes).
  • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

• xscen directly import xsdba

Does this PR introduce a breaking change?

xclim_train_args -> xsdba_train_args and so on, so yes.

Other information:

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[Zeitsperre]

Explicitly requesting changes so that we don't forget to replace the xsdba dependency with a stable version.

[Zeitsperre]

FYI, this will not pass the PyPI smell test. Pointing to git branches for dependencies is forbidden on PyPI (thankfully).

We can release a patch (for xsdba) when the branch (on xsdba) is merged.

[coxipi]

We could just have a new xsdba release before this PR is merged?

[Zeitsperre]

Yep. Exactly that.

[RondeauG]

This will be a breaking change.

We should instead support both options for a while, but issue a FutureWarning if someone uses xclim_train/adjust_args. The rest of the code can use the new names, just with xsdba_train/adjust_args = xclim_train/adjust_args for those cases.

[coxipi]

In extract.py::resample, there's an issue with the new xclim, presumably following the recent PR about missing method

  >           complete = ~xc.core.missing.MISSING_METHODS[missmeth](
                  da, target_frequency, initial_frequency
              )(**missing)

[aulemahal]

@coxipi Je m'en occupe, c'est ma faute!